feat(rpc-types-trace/parity): add creationMethod for create action #1621
+22
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jsvisa <[email protected]>
jsvisa
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg and
emhane
as code owners
mattsse
reviewed
Nov 5, 2024
Comment on lines
+307
to
+309
| /// None | ||
| #[default] | ||
| None, |
There was a problem hiding this comment.
is this actually a valid variant?
can't see any "none" in the referenced pr
should this be an Option instead and serialize null?
There was a problem hiding this comment.
I copied this field from CallType, as it also has the None variant
pub enum CallType {
/// None
#[default]
None,
/// Call
Call,
mattsse
approved these changes
Nov 6, 2024
mattsse
pushed a commit
to paradigmxyz/revm-inspectors
that referenced
this pull request
Nov 6, 2024
waiting for alloy-rs/alloy#1621 --------- Signed-off-by: jsvisa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
align with geth's flatcall trace, ref ethereum/go-ethereum#30539
Solution
PR Checklist